v0.1.5: standalone-readability pass — delink --strip provenance mode ([TT-NNNN]), Tier-2 dangling refs neutralized, verify/review-code giant skills split into reference/ on-demand files; guards now runtime-neutral (bun|node)

2026-09-25 00:09:37 +08:00
parent d6567b1842
commit 88204a90c8
74 changed files with 1417 additions and 1358 deletions
@@ -9,7 +9,7 @@
 > - `frontend/SKILL.md`
 >
 > (The `roadmap`, `requirements-elicitation`, `design`, and `plan-iterations`
-> referencing skills were archived 2026-08-21, [org-internal #3072] phase 3 — see
+> referencing skills were archived 2026-08-21, [TT-3072] phase 3 — see
 > `.octopus/archive/skills/`; their copies of this directive moved with them.)
 >
 > **When editing:** update this file only. Each skill references this file via a
@@ -70,6 +70,6 @@
  `review-dag` (review-artifact targets — same id feeds the
  `pipeline/{REVIEW_TYPE}` commit-status context; see review-artifact Phase
  Bindings). (The design-space/plan targets were archived 2026-08-21,
-  [org-internal #3072] phase 3.)
+  [TT-3072] phase 3.)
 - `{DIMENSION_COUNT}` — 10 (code review; 9 in standalone-bugfix mode), 3 (review-dag single gate), or 10 (process audit); used in
  the skill's SKILL.md reference text, not inside this template body
@@ -113,7 +113,7 @@ Each skill references this base template via `core/skills/_shared/review-orchest
 rather than inlining the JSON array. This centralization ensures the base
 permission surface stays consistent across all review/audit skills.

-**Tier-1 local exception** ([org-internal #1988]): migrated skills that write raw per-dimension
+**Tier-1 local exception** ([TT-1988]): migrated skills that write raw per-dimension
 findings to `<runs-root>/**` (e.g. `review-code`) add ONE scoped `edit` allow
 to the base set — `{ permission: "edit", pattern: "<runs-root>/**", action:
 "allow" }` — so the reviewer can write its OWN finding file. This is a
@@ -122,7 +122,7 @@ edit on the code under review, so rule #7 (auditor independence) holds. See
 `_shared/review-pipeline-phases.md` Phase A step 4 and `review-code/SKILL.md`
 Phase A step 3 for the inline extended array.

-Residual risk — accepted trade-off (TD/STD-F004, [org-internal #2688]): the grant is scoped
+Residual risk — accepted trade-off (TD/STD-F004, [TT-2688]): the grant is scoped
 to `<runs-root>/**`, wider than the reviewer's own findings file. Per-file
 narrowing was considered and rejected: findings paths are round- and
 dimension-dependent (`{slug}/reviews/{stage}/round{N}/findings-{DIMENSION_CODE}.json`),
@@ -132,7 +132,7 @@ residual exposure — a misbehaving reviewer could overwrite a sibling stage's
 Tier 1 files — is recorded here as accepted; auditor independence is
 unaffected (code under review lives outside `runs/`).

-### No bash for Explorer sub-agents (deliberate boundary, [org-internal #2115] RC4 / [org-internal #2126])
+### No bash for Explorer sub-agents (deliberate boundary, [TT-2115] RC4 / [TT-2126])

 Explorer sub-agents (Reviewer / auditor / Tool roles) have **no bash**. The
 `explorer` agent is built deny-by-default at
@@ -151,7 +151,7 @@ Synthesizer / Verifier's job (Worker sub-agents, which DO have bash via the
 `worker` agent defaults) — not the Reviewer's. Report the need in findings
 instead of attempting bash.

-> **[org-internal #2126] Task 2 conclusion — keep + document.** The `deny **` pushed per-tool
+> **[TT-2126] Task 2 conclusion — keep + document.** The `deny **` pushed per-tool
 > at `<harness-package>/src/session/prompt.ts` is the **session tool-enable /
 > disable map** (it disables `todowrite` / `task` / `experimental.primary_tools`
 > for subagents and allows forwarded MCP tools). It is NOT the source of the
@@ -165,4 +165,4 @@ instead of attempting bash.
 - `{REVISION_ROLE}` — "Developer" (code review), "Analyst" (review-dag single
  gate), or "Remediator" (process audit). The Worker role that revises
  artifacts between rounds. (The Architect/Planner revision roles belonged to
-  the archived design-space / iteration-plan targets, [org-internal #3072] phase 3.)
+  the archived design-space / iteration-plan targets, [TT-3072] phase 3.)
@@ -9,14 +9,14 @@ parameters and reference this doc rather than duplicating the shared mechanics.
 legitimately uses "auditor"/"Re-audit" terminology. All generic descriptions
 use `{REVIEWER_OR_AUDITOR}`.

-**Output model — two findings sinks** ([org-internal #1988] Tier 1 migration): raw per-dimension
+**Output model — two findings sinks** ([TT-1988] Tier 1 migration): raw per-dimension
 reviewer findings have ONE of two sinks, chosen per skill. The **synthesis**
 (human gate) and **commit status** are ALWAYS Tier 2 (Gitea) regardless of the
 findings sink.

 | Sink | Skills | Reviewer writes findings to | Synthesizer reads findings from |
 |---|---|---|---|
-| `tier1-local` (migrated) | `review-code`, `review-artifact` (live targets: review-dag, audit-process; the roadmap/design-space/plan targets were archived 2026-08-21, [org-internal #3072] phase 3) | `<runs-root>/{slug}/reviews/{stage}/round{N}/findings-{DIMENSION_CODE}.json` (validated by `core/schemas/reviewer-output.schema.json`) | the local finding files (no Gitea call) |
+| `tier1-local` (migrated) | `review-code`, `review-artifact` (live targets: review-dag, audit-process; the roadmap/design-space/plan targets were archived 2026-08-21, [TT-3072] phase 3) | `<runs-root>/{slug}/reviews/{stage}/round{N}/findings-{DIMENSION_CODE}.json` (validated by `core/schemas/reviewer-output.schema.json`) | the local finding files (no Gitea call) |
 | `tier2-comment` (fallback) | _(none — all targets migrated)_ | Gitea PR/issue comment via `工单评论 API（见 TERMINOLOGY）` (Pattern 5) | `工单评论 API（见 TERMINOLOGY）` (Pattern 3) |

 Migration complete — every review/audit skill now outputs `tier1-local`; the
@@ -61,7 +61,7 @@ in `_shared/gitea-write-patterns.md`.
   `stage` = `{REVIEW_TYPE}`, `produced_by` = `Orchestrator`, `schema` = the
   review-status `$id`).

-1. **Tool-availability probe** (defense-in-depth, [org-internal #2115] RC1 / [org-internal #2126]). Before
+1. **Tool-availability probe** (defense-in-depth, [TT-2115] RC1 / [TT-2126]). Before
   dispatching any {REVIEWER_OR_AUDITOR}, verify reviewers will be able to read
   wiki artifacts (requirements / design / plan / prior-review reports). A
   reviewer that cannot read its inputs aborts or hallucinates — catch this ONCE
@@ -74,7 +74,7 @@ in `_shared/gitea-write-patterns.md`.
      reachable; anything else — timeout, connection refused, 5xx — is
      unreachable). If reachable → continue to step 2.
    - **Fallback path** (when REST is unreachable, e.g. a
-      cross-repo scenario [org-internal #2115]): verify the **local wiki clone** at
+      cross-repo scenario [TT-2115]): verify the **local wiki clone** at
     `<wiki-clone-root>/{repo}-wiki/` is readable —
     `glob(pattern="*.md", path="<wiki-clone-root>/{repo}-wiki/")`. If the clone
     is readable → continue to step 2; reviewers use the local clone (see
@@ -266,7 +266,7 @@ Otherwise:
   - The {REVISION_ROLE} MUST NOT receive the full text of all findings inline —
     use finding-file path / comment references only to avoid context explosion.
   - Convergence status: blockers/majors remaining vs. previous round.
-   - **Revision survival ([org-internal #2601]) — primary path**: the task tool's completion
+   - **Revision survival ([TT-2601]) — primary path**: the task tool's completion
     output includes a `task_id`; passing it back resumes the SAME
     {REVISION_ROLE} subagent session instead of creating a fresh one. Round 1:
     persist the returned `task_id` with the round's working-notes entry (it
@@ -322,24 +322,24 @@ After the {REVISION_ROLE} completes revision:
  `core/schemas/review-status.schema.json`).
 - `review-code` skill: **2** default / **3** high-risk (a BLOCKER survived a
  round, or the diff touches a frozen cross-session contract) —
-  `<instance-root>/workflow-routing.yaml` `review.max_rounds` ([org-internal #3567], process-diet
+  `<instance-root>/workflow-routing.yaml` `review.max_rounds` ([TT-3567], process-diet
  P0b). At budget without convergence: STOP, register the remaining
  BLOCKER/MAJOR findings as TD registry rows, then compute the verdict
  with the shared three-tier ladder (`core/schemas/synthesis.schema.json`
  `overall_verdict` + `core/skills/_shared/review-orchestrator-rules.md`
  rule 3): FAIL if any BLOCKER or FAIL dimension remains, else WARN,
-  PASS only if every remaining dimension is PASS ([org-internal #4786]:
+  PASS only if every remaining dimension is PASS ([TT-4786]:
  the prior binary "else PASS" wording silently upgraded WARN-eligible
  outcomes to PASS; a PASS round has already stopped at the convergence
  table above, so the residual tail lands WARN or FAIL). The debt is
  carried by those TD registry rows
  (see `review-code/SKILL.md` Phase D). This
-  supersedes the 2026-08-25 [org-internal #3380] calibration (p50=2, p95=5, n=66): the runs
+  supersedes the 2026-08-25 [TT-3380] calibration (p50=2, p95=5, n=66): the runs
  past round 3 are the marathon tail this budget exists to cut; their residue
  flows to the TD registry instead of reviewer rounds. Ledger:
  `docs/workflow-refactor/thresholds-ledger.md`.

-Rationale for `review-artifact` = 3 (evaluated in [org-internal #1969], replacing the prior blanket
+Rationale for `review-artifact` = 3 (evaluated in [TT-1969], replacing the prior blanket
 default of 5): (1) the Round-3 Escalation Guardrail below already detects
 non-convergence at the start of round 3; (2) the INFO-disposition rule below
 removes spurious WARN rounds previously caused by non-blocking INFO findings;
@@ -350,8 +350,8 @@ reaches round 4 — its round budget is 2/3, see the binding above.)

 **Provisional, not empirically validated**: the four safeguards make `review-artifact`=3
 defensible, but it has no fresh run-data yet. Treat it as a hypothesis to
-confirm via the retrospective signal ([org-internal #1834]; gate-trim's landing machinery was
-retired, [org-internal #3072] phase 3 — the check is observational, not a trim proposal): if
+confirm via the retrospective signal ([TT-1834]; gate-trim's landing machinery was
+retired, [TT-3072] phase 3 — the check is observational, not a trim proposal): if
 live `review-artifact` runs frequently hit round 3 still improving yet are
 forced to stop at WARN/FAIL, bump it back to 4.

@@ -379,8 +379,8 @@ block convergence and NEVER drive a reviser round.
 **Round-3 Escalation Guardrail** (applies to the `review-artifact` skill's
 live targets — the process audit target AND the review-dag single-gate
 target; the roadmap / design / plan targets were archived 2026-08-21,
-[org-internal #3072] phase 3). `review-code` does NOT use this guardrail; it uses its round
-budget ([org-internal #3567], see the `{MAX_ROUNDS}` binding above).
+[TT-3072] phase 3). `review-code` does NOT use this guardrail; it uses its round
+budget ([TT-3567], see the `{MAX_ROUNDS}` binding above).

 At the start of round 3, if the combined blocker+major count is still >50% of
 round 1's count, STOP the loop and surface to the user:
@@ -391,7 +391,7 @@ round 1's count, STOP the loop and surface to the user:
 > (a) Return to upstream — for the `process` audit target, escalate to the
 > octopus maintainer for a process-level redesign (the legacy producer skills
 > `roadmap` / `requirements-elicitation` / `design` / `plan-iterations` were
-> archived 2026-08-21, [org-internal #3072] phase 3 — `<instance-root>/archive/`), then restart this
+> archived 2026-08-21, [TT-3072] phase 3 — `<instance-root>/archive/`), then restart this
 > review at round 1.
 > (b) Continue iterating — accept that more rounds may be needed (capped by
 > `{MAX_ROUNDS}`).
@@ -406,7 +406,7 @@ review and escalate to a human, or (b) continue into round 4 — via the
 `question` tool. The guard means "escalate with a choice", NOT "force-stop".
 The choice is UNCONDITIONAL at the round-3→4 transition — instance skills may
 narrow when an escalation *variant* (e.g. a design-level decision) fires, but
-never narrow the choice gate itself. The call MUST be optionized ([org-internal #3378]):
+never narrow the choice gate itself. The call MUST be optionized ([TT-3378]):
 two options — `Stop & escalate to a human` (first, when recommended) /
 `Continue into round 4` — with `stage` set to the running skill's stage so
 auto-approval applies in autonomous mode; free-text asking is a spec
@@ -414,12 +414,12 @@ violation.
 Instance: review-dag D4 option-b (`review-artifact/SKILL.md` §"Round-3
 Escalation Guardrail interaction") — the sole live instance, its D4 round cap
 (≤4) being the only budget that reaches round 4 (`review-code` is capped 2/3,
-[org-internal #3567]).
-Rationale (retro 2026-08-21 / [org-internal #3050]): unattended late-round loops drift into
+[TT-3567]).
+Rationale (retro 2026-08-21 / [TT-3050]): unattended late-round loops drift into
 review marathons — the choice forces the design-level stall to surface to a
 human at round 4 instead of round 6.

-**Efficiency optimization**: From round 2 onward ([org-internal #2598]), only spawn
+**Efficiency optimization**: From round 2 onward ([TT-2598]), only spawn
 {REVIEWER_OR_AUDITOR}s for dimensions that had FAIL, WARN, or UNRESOLVED in
 the previous round. Every 2 rounds, run a full {DIMENSION_COUNT}-reviewer
 sweep to catch regressions. From round 2 onward reviewer input is also
@@ -486,7 +486,7 @@ not the round-1 full set.
    `REQUEST_REVIEW` registration to be recorded, and only THEN ask the human
   to approve. Approving before the reviewer is registered produces
   `official: false` on the approval — the gate treats the PR as unapproved
-   and the approval must be re-done. ([org-internal #1931]: audit R2→R3 re-loop + re-approve,
+   and the approval must be re-done. ([TT-1931]: audit R2→R3 re-loop + re-approve,
   ~30min wasted on exactly this ordering.)

 4. Present the final report to the user and obtain approval via the `question`
@@ -31,7 +31,7 @@ After revising, report a summary of changes made:
 - Findings waived as cosmetic MINOR (round 2+): {WAIVED-{id} → reason}

 Persist that summary to `{RETURN_FILE}` as your LAST action, BEFORE
-returning it — worker-report persistence ([org-internal #2847], see
+returning it — worker-report persistence ([TT-2847], see
 `.octopus/skills/_shared/worker-report-persistence.md`). The persisted copy
 is the report of record; if your completion notification is lost, the
 Orchestrator recovers the revision outcome from this file.
@@ -1,7 +1,7 @@
 > Core 中立版（Increment 6a 改写，原 deferHard verbatim）。编号与条目结构严格不变（C-2 不变量）；实例术语按 `core/adapters/TERMINOLOGY.md` 绑定。
 name: Coordinator
 purpose: >
-  Pool dispatch coordinator (billing-v2 [org-internal #4041] §7, REQ-F-012): a wake-driven,
+  Pool dispatch coordinator (billing-v2 [TT-4041] §7, REQ-F-012): a wake-driven,
  STATELESS decision-maker session living in the pool pod alongside workers.
  List eligible issues (Gitea API, scoped token) → produce DAG-aware dispatch
  proposals → commit each dispatch through the N-16 assignment API
@@ -62,14 +62,14 @@ agents_md:
 #
 # Security posture (AC-5, see docs/security/threat-model.md §自治批处理):
 # the coordinator authenticates with a workspace-level API token
-# (TD-687/[org-internal #3898] owner-minted, jti-revocable, role claim org_role). TODAY'S
+# (TD-687/[TT-3898] owner-minted, jti-revocable, role claim org_role). TODAY'S
 # mint shape hardcodes org_role=viewer — read-capable only (assignment table
 # + pool surfaces); the editor-capable mint needed for dispatch submission is
-# an explicit deployment-time decision on the [org-internal #3898] channel (not landed with
+# an explicit deployment-time decision on the [TT-3898] channel (not landed with
 # N-19). Either way the token can NOT mint tokens, touch wallet internals, or
 # merge PRs — the merge gate stays human (E-4).
 #
-# Worker-report persistence ([org-internal #2847] — see
+# Worker-report persistence ([TT-2847] — see
 # core/skills/_shared/worker-report-persistence.md): a Coordinator
 # sub-agent persists its FINAL RETURN REPORT to disk as its LAST action,
 # before returning — <runs-root>/{slug}/workers/{chunk-id}-worker-{seq}.md
@@ -15,7 +15,7 @@ agents_md:
  - claim-discipline
  - compact

-# Worker-report persistence ([org-internal #2847], retro-2696 AI#2 — see
+# Worker-report persistence ([TT-2847], retro-2696 AI#2 — see
 # core/skills/_shared/worker-report-persistence.md): every Producer
 # sub-agent persists its FINAL RETURN REPORT to disk as its LAST action,
 # before returning — <runs-root>/{slug}/workers/{chunk-id}-worker-{seq}.md
@@ -23,7 +23,7 @@ agents_md:
 # else /tmp/octopus/{chunk-id}-worker-{seq}.md. The persisted copy is the
 # report of record; the task notification is a convenience copy.
 #
-# Working-notes contract ([org-internal #2600] — see core/templates/runs-layout.md §
+# Working-notes contract ([TT-2600] — see core/templates/runs-layout.md §
 # working-notes.md): at stage exit the Producer appends ONE entry (≤30 lines:
 # decisions and why, dead ends, reviewer feedback that changed the work, hints
 # for the next stage) to <runs-root>/{slug}/working-notes.md, and registers
@@ -14,7 +14,7 @@ agents_md:
  - ticket-lifecycle
  - compact

-# Working-notes contract ([org-internal #2600] — see core/templates/runs-layout.md §
+# Working-notes contract ([TT-2600] — see core/templates/runs-layout.md §
 # working-notes.md): the Reviewer side appends ONE distilled entry via the
 # Synthesizer at review convergence — never per dimension dispatch (9
 # dimension dispatches = 1 entry) — to <runs-root>/{slug}/working-notes.md.
@@ -12,7 +12,7 @@ agents_md:
  - claim-discipline
  - compact

-# Working-notes contract ([org-internal #2600] — see core/templates/runs-layout.md §
+# Working-notes contract ([TT-2600] — see core/templates/runs-layout.md §
 # working-notes.md): Tool agents append to <runs-root>/{slug}/working-notes.md
 # ONLY when the task produced a load-bearing finding (e.g. image evidence that
 # changed a decision) — not for routine single-shot output.
@@ -15,7 +15,7 @@ agents_md:
  - claim-discipline
  - compact

-# Worker-report persistence ([org-internal #2847], retro-2696 AI#2 — see
+# Worker-report persistence ([TT-2847], retro-2696 AI#2 — see
 # core/skills/_shared/worker-report-persistence.md): the Verifier
 # persists its FINAL RETURN REPORT (DoD verdict + evidence pointers) to disk
 # as its LAST action, before returning —
@@ -23,7 +23,7 @@ agents_md:
 # else /tmp/octopus/{chunk-id}-worker-{seq}.md. The persisted copy is the
 # report of record; the task notification is a convenience copy.
 #
-# Working-notes contract ([org-internal #2600] — see core/templates/runs-layout.md §
+# Working-notes contract ([TT-2600] — see core/templates/runs-layout.md §
 # working-notes.md): the Verifier appends ONE entry at verify exit (what the
 # DoD sweep caught, flaky/deferral context the next run should know). The
 # Phase 5.5 archive step additionally inlines the final working-notes.md
@@ -42,7 +42,7 @@
 - **Commit SHA**: `{SHA}` (the HEAD commit being reviewed).
 - **Review type**: `{REVIEW_TYPE}` — one of `review-code`, `review-dag`,
  `audit-process` (the `review-design-space` / `review-iteration-plan` /
-  `review-roadmap` targets were archived 2026-08-21, [org-internal #3072] phase 3 — their
+  `review-roadmap` targets were archived 2026-08-21, [TT-3072] phase 3 — their
  historical synthesis data remains readable).

 ## Your Job
@@ -189,7 +189,7 @@
 9. Persist your return summary (the exact text from the Return Format
   below) to `<runs-root>/{slug}/reviews/{stage}/round{N}/synthesis-return.md`
   (Tier 1) as your LAST action, BEFORE returning it — worker-report
-   persistence ([org-internal #2847], `_shared/worker-report-persistence.md`). The persisted
+   persistence ([TT-2847], `_shared/worker-report-persistence.md`). The persisted
   copy is the report of record; if your completion notification is lost, the
   Orchestrator recovers the round verdict from this file.

@@ -211,7 +211,7 @@ synthesis JSON — it is already posted to the pipeline PR / source issue
 comment (for audit-process runs, the wiki page `audit/{date}/round{N}/synthesis`).
 Persist this summary verbatim to
 `<runs-root>/{slug}/reviews/{stage}/round{N}/synthesis-return.md` before
-returning (step 9 above — worker-report persistence [org-internal #2847]).
+returning (step 9 above — worker-report persistence [TT-2847]).

 ```
 ## Synthesis Complete
@@ -3,7 +3,7 @@
 > Canonical convention for every worker sub-agent dispatch (roles whose
 > `agent:` is `worker` — Producer sub-roles, Verifier, Synthesizer, …),
 > foreground or background (`task background=true`). Origin: retro WWW#5 /
-> [org-internal #2696] action item #2 ([org-internal #2847]) — at least one confirmed case where a
+> [TT-2696] action item #2 ([TT-2847]) — at least one confirmed case where a
 > background worker's completion report reached the orchestrating session
 > only via the task-tool notification; the notification was lost and the
 > report evaporated, leaving nothing but reverse-engineering from artifacts.